Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Bombing Raids should be dealt with first!" error. #11848

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Fix "Bombing Raids should be dealt with first!" error. #11848

merged 1 commit into from
Aug 3, 2023

Commits on Aug 3, 2023

  1. Fix "Bombing Raids should be dealt with first!" error. 

    This could happen if a unit is sent to bomb somewhere but then gets moved again, resulting in an empty battle (which gets skipped during the bombing battle phase).
This removes the logic for considering empty for the purposes of this error. Also removes code to cancel such battle right before throwing the error, since the expectation is that we shouldn't be hitting this codepath, so no need to try to "handle" the situation.

Also, some related cleanup.
    @asvitkine
    asvitkine committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    975916c View commit details
    Browse the repository at this point in the history