Checkstyle: Fix top-level class violations in test code #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I ask why this is important or more worthwhile than the issues I listed in #1638? |
It's probably not. 😃 But I'm spending most of my free time working on prototyping the Serialization Proxy changes. When I see that there's no Checkstyle PRs waiting to be merged, I'll walk away from the prototyping for an hour or so and fix a few more warnings in order to keep making headway there. I have #1645 bookmarked. Once I finish the Serialization Proxy changes (it could take quite a while), I'll mosey on over there. |
|
Cool. Be awesome if that bug can be fixed, even if it won't be backwards compatible. |
ssoloff
deleted the
checkstyle-fix-top-level-class-violations-in-test-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes violations of the Checkstyle OneTopLevelClass rule in test code.
In most cases, the fix was simply to nest a top-level package-private class under the sole top-level class that used it. In one case, I removed an unused class (
ThrowingRandomSource).The changes in this PR are more easily reviewed when whitespace changes are ignored (
?w=1).