Checkstyle: Fix top-level class violations in test code

gradle.properties

@@ -1,2 +1,2 @@
 checkstyleMainMaxWarnings=5409
-checkstyleTestMaxWarnings=286
+checkstyleTestMaxWarnings=269

src/test/java/games/strategy/engine/chat/ChatTest.java

@@ -185,37 +185,36 @@ public void run() {
     }
     assertEquals(m_serverChatListener.m_players.size(), 0);
   }
-}
 
+  private static class TestChatListener implements IChatListener {
+    public List<INode> m_players;
+    public List<String> m_messages = new ArrayList<>();
+    public List<Boolean> m_thirdPerson = new ArrayList<>();
+    public List<String> m_from = new ArrayList<>();
 
-class TestChatListener implements IChatListener {
-  public List<INode> m_players;
-  public List<String> m_messages = new ArrayList<>();
-  public List<Boolean> m_thirdPerson = new ArrayList<>();
-  public List<String> m_from = new ArrayList<>();
+    @Override
+    public void updatePlayerList(final Collection<INode> players) {
+      synchronized (this) {
+        m_players = new ArrayList<>(players);
+      }
+    }
 
-  @Override
-  public void updatePlayerList(final Collection<INode> players) {
-    synchronized (this) {
-      m_players = new ArrayList<>(players);
+    @Override
+    public void addMessageWithSound(final String message, final String from, final boolean thirdperson,
+        final String sound) {
+      synchronized (this) {
+        m_messages.add(message);
+        m_thirdPerson.add(thirdperson);
+        m_from.add(from);
+      }
     }
-  }
 
-  @Override
-  public void addMessageWithSound(final String message, final String from, final boolean thirdperson,
-      final String sound) {
-    synchronized (this) {
-      m_messages.add(message);
-      m_thirdPerson.add(thirdperson);
-      m_from.add(from);
+    @Override
+    public void addMessage(final String message, final String from, final boolean thirdperson) {
+      addMessageWithSound(message, from, thirdperson, SoundPath.CLIP_CHAT_MESSAGE);
     }
-  }
 
-  @Override
-  public void addMessage(final String message, final String from, final boolean thirdperson) {
-    addMessageWithSound(message, from, thirdperson, SoundPath.CLIP_CHAT_MESSAGE);
+    @Override
+    public void addStatusMessage(final String message) {}
   }
-
-  @Override
-  public void addStatusMessage(final String message) {}
 }

src/test/java/games/strategy/engine/lobby/server/ModeratorControllerTest.java

@@ -58,7 +58,7 @@ public Void answer(final InvocationOnMock invocation) throws Throwable {
     m_controller.boot(booted);
     assertTrue(m_listener.getRemoved().contains(booted));
   }
-  
+
   @Test
   public void testCantResetAdminPassword() throws UnknownHostException {
     MessageContext.setSenderNodeForThread(m_adminNode);
@@ -77,21 +77,20 @@ public void testAssertAdmin() throws UnknownHostException {
     MessageContext.setSenderNodeForThread(m_adminNode);
     assertTrue(m_controller.isAdmin());
   }
-}
 
+  private static class ConnectionChangeListener implements IConnectionChangeListener {
+    final List<INode> m_removed = new ArrayList<>();
 
-class ConnectionChangeListener implements IConnectionChangeListener {
-  final List<INode> m_removed = new ArrayList<>();
+    @Override
+    public void connectionAdded(final INode to) {}
 
-  @Override
-  public void connectionAdded(final INode to) {}
-
-  @Override
-  public void connectionRemoved(final INode to) {
-    m_removed.add(to);
-  }
+    @Override
+    public void connectionRemoved(final INode to) {
+      m_removed.add(to);
+    }
 
-  public List<INode> getRemoved() {
-    return m_removed;
+    public List<INode> getRemoved() {
+      return m_removed;
+    }
   }
 }

src/test/java/games/strategy/engine/message/unifiedmessenger/ChannelMessengerTest.java

@@ -142,49 +142,47 @@ private static void assertCallCountIs(final ChannelSubscribor subscribor, final
     }
     assertEquals(expected, subscribor.getCallCount());
   }
-}
-
 
-interface IChannelBase extends IChannelSubscribor {
-  void testNoParams();
+  private interface IChannelBase extends IChannelSubscribor {
+    void testNoParams();
 
-  void testPrimitives(int a, short b, long c, byte d, boolean e, float f);
+    void testPrimitives(int a, short b, long c, byte d, boolean e, float f);
 
-  void testString(String a);
-
-  void testArray(int[] ints, short[] shorts, byte[] bytes, boolean[] bools, float[] floats, Object[] objects);
-}
+    void testString(String a);
 
+    void testArray(int[] ints, short[] shorts, byte[] bytes, boolean[] bools, float[] floats, Object[] objects);
+  }
 
-class ChannelSubscribor implements IChannelBase {
-  private int m_callCount = 0;
+  private static class ChannelSubscribor implements IChannelBase {
+    private int m_callCount = 0;
 
-  private synchronized void incrementCount() {
-    m_callCount++;
-  }
+    private synchronized void incrementCount() {
+      m_callCount++;
+    }
 
-  public synchronized int getCallCount() {
-    return m_callCount;
-  }
+    public synchronized int getCallCount() {
+      return m_callCount;
+    }
 
-  @Override
-  public void testNoParams() {
-    incrementCount();
-  }
+    @Override
+    public void testNoParams() {
+      incrementCount();
+    }
 
-  @Override
-  public void testPrimitives(final int a, final short b, final long c, final byte d, final boolean e, final float f) {
-    incrementCount();
-  }
+    @Override
+    public void testPrimitives(final int a, final short b, final long c, final byte d, final boolean e, final float f) {
+      incrementCount();
+    }
 
-  @Override
-  public void testString(final String a) {
-    incrementCount();
-  }
+    @Override
+    public void testString(final String a) {
+      incrementCount();
+    }
 
-  @Override
-  public void testArray(final int[] ints, final short[] shorts, final byte[] bytes, final boolean[] bools,
-      final float[] floats, final Object[] objects) {
-    incrementCount();
+    @Override
+    public void testArray(final int[] ints, final short[] shorts, final byte[] bytes, final boolean[] bools,
+        final float[] floats, final Object[] objects) {
+      incrementCount();
+    }
   }
 }

src/test/java/games/strategy/engine/message/unifiedmessenger/RemoteMessengerTest.java

@@ -323,44 +323,41 @@ public void run() {
       shutdownServerAndClient(server, client);
     }
   }
-}
-
-
-interface IFoo extends IRemote {
-  void foo();
-}
 
+  private interface IFoo extends IRemote {
+    void foo();
+  }
 
-interface ITestRemote extends IRemote {
-  int increment(int testVal);
-
-  void testVoid();
+  private interface ITestRemote extends IRemote {
+    int increment(int testVal);
 
-  void throwException() throws Exception;
-}
+    void testVoid();
 
+    void throwException() throws Exception;
+  }
 
-class TestRemote implements ITestRemote {
-  public static final String EXCEPTION_STRING = "AND GO";
-  private INode m_senderNode;
+  private static class TestRemote implements ITestRemote {
+    public static final String EXCEPTION_STRING = "AND GO";
+    private INode m_senderNode;
 
-  @Override
-  public int increment(final int testVal) {
-    m_senderNode = MessageContext.getSender();
-    return testVal + 1;
-  }
+    @Override
+    public int increment(final int testVal) {
+      m_senderNode = MessageContext.getSender();
+      return testVal + 1;
+    }
 
-  @Override
-  public void testVoid() {
-    m_senderNode = MessageContext.getSender();
-  }
+    @Override
+    public void testVoid() {
+      m_senderNode = MessageContext.getSender();
+    }
 
-  @Override
-  public void throwException() throws Exception {
-    throw new Exception(EXCEPTION_STRING);
-  }
+    @Override
+    public void throwException() throws Exception {
+      throw new Exception(EXCEPTION_STRING);
+    }
 
-  public INode getLastSenderNode() {
-    return m_senderNode;
+    public INode getLastSenderNode() {
+      return m_senderNode;
+    }
   }
 }

src/test/java/games/strategy/net/MessengerTest.java

@@ -291,80 +291,78 @@ public void testManyClients() throws UnknownHostException, CouldNotLogInExceptio
       clients.get(i).shutDown();
     }
   }
-}
-
-
-class MessageListener implements IMessageListener {
-  private final List<Serializable> messages = new ArrayList<>();
-  private final ArrayList<INode> senders = new ArrayList<>();
-  private final Object lock = new Object();
 
-  @Override
-  public void messageReceived(final Serializable msg, final INode from) {
-    synchronized (lock) {
-      messages.add(msg);
-      senders.add(from);
-      lock.notifyAll();
+  private static class MessageListener implements IMessageListener {
+    private final List<Serializable> messages = new ArrayList<>();
+    private final ArrayList<INode> senders = new ArrayList<>();
+    private final Object lock = new Object();
+
+    @Override
+    public void messageReceived(final Serializable msg, final INode from) {
+      synchronized (lock) {
+        messages.add(msg);
+        senders.add(from);
+        lock.notifyAll();
+      }
     }
-  }
 
-  public void clearLastMessage() {
-    synchronized (lock) {
-      if (messages.isEmpty()) {
-        waitForMessage();
+    public void clearLastMessage() {
+      synchronized (lock) {
+        if (messages.isEmpty()) {
+          waitForMessage();
+        }
+        messages.remove(0);
+        senders.remove(0);
       }
-      messages.remove(0);
-      senders.remove(0);
     }
-  }
 
-  public Object getLastMessage() {
-    synchronized (lock) {
-      if (messages.isEmpty()) {
-        waitForMessage();
+    public Object getLastMessage() {
+      synchronized (lock) {
+        if (messages.isEmpty()) {
+          waitForMessage();
+        }
+        assertFalse(messages.isEmpty());
+        return messages.get(0);
       }
-      assertFalse(messages.isEmpty());
-      return messages.get(0);
     }
-  }
 
-  public INode getLastSender() {
-    synchronized (lock) {
-      if (messages.isEmpty()) {
-        waitForMessage();
+    public INode getLastSender() {
+      synchronized (lock) {
+        if (messages.isEmpty()) {
+          waitForMessage();
+        }
+        return senders.get(0);
       }
-      return senders.get(0);
     }
-  }
 
-  private void waitForMessage() {
-    try {
-      lock.wait(1500);
-    } catch (final InterruptedException e) {
-      fail("unexpected exception: " + e.getMessage());
+    private void waitForMessage() {
+      try {
+        lock.wait(1500);
+      } catch (final InterruptedException e) {
+        fail("unexpected exception: " + e.getMessage());
+      }
     }
-  }
 
-  public int getMessageCount() {
-    synchronized (lock) {
-      return messages.size();
+    public int getMessageCount() {
+      synchronized (lock) {
+        return messages.size();
+      }
     }
   }
-}
-
 
-class MultipleMessageSender implements Runnable {
-  IMessenger m_messenger;
+  private static class MultipleMessageSender implements Runnable {
+    IMessenger m_messenger;
 
-  public MultipleMessageSender(final IMessenger messenger) {
-    m_messenger = messenger;
-  }
+    public MultipleMessageSender(final IMessenger messenger) {
+      m_messenger = messenger;
+    }
 
-  @Override
-  public void run() {
-    Thread.yield();
-    for (int i = 0; i < 100; i++) {
-      m_messenger.broadcast(i);
+    @Override
+    public void run() {
+      Thread.yield();
+      for (int i = 0; i < 100; i++) {
+        m_messenger.broadcast(i);
+      }
     }
   }
 }