Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-align main and llvm-head #5331

Closed
wants to merge 3 commits into from
Closed

Re-align main and llvm-head #5331

wants to merge 3 commits into from

Conversation

gflegar
Copy link
Collaborator

@gflegar gflegar commented Dec 4, 2024

We have a couple of PRs that landed in the llvm-head branch that are not in main.

Merging those into main to prevent further divergence between branches.

wkpark and others added 2 commits December 4, 2024 09:09
from #2757

 * fix deprecation warning
 * use bash shell to fix `az storage ...` console  error.
* `-DLLVM_ENABLE_DIA_SDK=OFF` added to fix `DIA_SDK` dependency -
`"ninja: error: 'C:/Program Files/Microsoft Visual
Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by
'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd',
missing and no known rule to make it"`.

the latest windows llvm build is available at
https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows

It would be nice to have default llvm;mlir compiler on the official
trion build system for someone who trying to develop solve some windows
related issue even if windows is not officially supported.

p.s.: and I'd like to thank all triton developers for their hard work!
Right now we are hitting the following issues in

https://github.com/triton-lang/triton/actions/runs/12148740919/job/33877869004:

> The macOS-12 environment is deprecated, consider switching to
> macOS-13, macOS-14 (macos-latest) or macOS-15. For more details,
> see actions/runner-images#10721
@gflegar gflegar requested a review from ptillet as a code owner December 4, 2024 12:06
@gflegar gflegar requested review from Jokeren and antiagainst and removed request for ptillet December 4, 2024 12:07
@gflegar
Copy link
Collaborator Author

gflegar commented Dec 4, 2024

Argh... llvm-head is a moving target, created a copy of the branch that includes only the two PRs I originally wanted to push here, and opened #5334 instead.

@gflegar gflegar closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants