[WIP] ControlParameter inordinatly slow on big file. #1386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troessner
commented
Jul 3, 2018
| it 'runs on a complicated source file in less than 10 seconds' do | ||
| examiner = Reek::Examiner.new source, filter_by_smells: ['ControlParameter'] | ||
| # This is the actual test | ||
| # expect(examiner.smells.size).to perform_under(10).sec |
There was a problem hiding this comment.
Yes, definitely worth a try. I have no experience with this kind of spec but it looks very useful.
mvz
reviewed
Jul 3, 2018
| gem 'yard', '~> 0.9.5' | ||
|
|
||
| if RUBY_VERSION >= '2.3' |
troessner
force-pushed
the
control-parameter-inordinatly-slow-on-big-file
branch
8 times, most recently
from
877a727 to
0a2b00e
Compare
troessner
force-pushed
the
control-parameter-inordinatly-slow-on-big-file
branch
from
0a2b00e to
cf84d8c
Compare
|
Problem solved via #1389, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for #1381