Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve control parameter recursion performance #1389

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

mvz
Copy link
Collaborator

@mvz mvz commented Jul 9, 2018

Simple fix for #1381. Could use some (performance) tests. Based on the research by @troessner described in #1381 (comment).

@troessner
Copy link
Owner

Oh, this is even explicitly mentioned in our method docs for Node.each_node:

      # If a type is searched for *and* listed in ignoring, it will be yielded
      # but traversal will not continue to its children.

Merged!

@troessner troessner merged commit 8fc19f3 into master Jul 10, 2018
@troessner troessner deleted the simple-fix-control-parameter branch July 10, 2018 07:57
@mvz mvz mentioned this pull request Jul 10, 2018
@troessner
Copy link
Owner

Wow, this change seems to have fixed our ControlParameter performance problems completely, very nice work @mvz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants