Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v5.0.2. #1391

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Prepare v5.0.2. #1391

merged 1 commit into from
Jul 10, 2018

Conversation

troessner
Copy link
Owner

No description provided.

@@ -2,6 +2,10 @@

## Unreleased

## 5.0.2 (2018-07-10)

* (mvz) Parser 2.5.1.1 seems broken. Disallow it.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1389 should be added here.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like an internal change that is opaque to our users. AFAIR we don't put internal changes into our release notes to not confuse our users - i'm a bit confused why you want to add this now?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I guess you are considering our poor performance as some kind of bug and we always mention bugfixes, right? Ok, good point, let me add it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, it's a user-facing problem we fixed.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Copy link
Collaborator

@mvz mvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(No longer) Waiting for Travis ...

@mvz mvz merged commit 9820a95 into master Jul 10, 2018
@mvz mvz deleted the prepare-v5.0.2 branch July 10, 2018 12:24
@mvz
Copy link
Collaborator

mvz commented Jul 10, 2018

Release at will!

@troessner
Copy link
Owner Author

And released it is ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants