Fixes save preset button not showing up sometimes #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... on adjusting volume or time period on sound from a saved preset tag #172
ashutoshgngwr
added a commit
that referenced
this pull request
Sep 3, 2020
the move from SeekBar to Slider UI component reintroduced the bug resolved in #175. This was an oversight due to API differenced and could have been prevented if I had added the test-case for this specific scenario. Now it's and this bug shouldn't find its way into the app again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The save preset button in the Sound library would not show when a saved preset was played and then volume or time period of a sound was readjusted. This is not the intended behavior.
Changes
PlaybackManagerSoundLibraryFragmentso they don't mess with on-going seek action by the userTesting
Others