Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds app intro component #318

Merged
merged 8 commits into from
Sep 4, 2020
Merged

Adds app intro component #318

merged 8 commits into from
Sep 4, 2020

Conversation

ashutoshgngwr
Copy link
Member

Changes

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

Copy link
Member Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 1
           

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #318 into master will increase coverage by 0.95%.
The diff coverage is 97.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   85.76%   86.71%   +0.95%     
==========================================
  Files          29       30       +1     
  Lines        1510     1596      +86     
  Branches      177      178       +1     
==========================================
+ Hits         1295     1384      +89     
+ Misses        115      114       -1     
+ Partials      100       98       -2     
Flag Coverage Δ
#android 85.97% <97.61%> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ashutoshgngwr/noice/sound/player/PlayerManager.kt 84.71% <ø> (+3.11%) ⬆️
...ava/com/github/ashutoshgngwr/noice/MainActivity.kt 78.22% <91.66%> (+0.17%) ⬆️
...hutoshgngwr/noice/fragment/SoundLibraryFragment.kt 86.60% <92.59%> (-1.13%) ⬇️
...com/github/ashutoshgngwr/noice/AppIntroActivity.kt 100.00% <100.00%> (ø)
...thub/ashutoshgngwr/noice/fragment/AboutFragment.kt 99.02% <100.00%> (+0.17%) ⬆️
...ava/com/github/ashutoshgngwr/noice/sound/Preset.kt 93.18% <100.00%> (-2.28%) ⬇️
cast-receiver/src/library.mock.ts 100.00% <0.00%> (ø)
cast-receiver/src/status_ui_handler.ts 97.43% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd2957a...749c30c. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit 65a108d into master Sep 4, 2020
@ashutoshgngwr ashutoshgngwr deleted the feat/app-intro branch September 4, 2020 20:23
@ashutoshgngwr ashutoshgngwr added this to the 0.10.x milestone Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What does timer slider do?
1 participant