Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Add some control UI components for parameters of post-process #50

Merged
merged 8 commits into from
May 9, 2020
Merged

[PR] Add some control UI components for parameters of post-process #50

merged 8 commits into from
May 9, 2020

Conversation

tucan9389
Copy link
Owner

@tucan9389 tucan9389 commented May 4, 2020 •
edited
Loading

Cautions

PR Points

  • Create PreprocessOptions and PostprocessOptions for PoseEstimator protocol
    • PreprocessOptions contains the preprocess option like cropArea
    • PostprocessOptions contains the postprocess options like partIndex, partThreshold and humanType
  • Add some control UI and group the UI components
    • Add new sections
      • Postprocess Method
      • Part
      • Pair
      • Human
    • Add new control UI
      • Human Type (UISegmentedControl)
      • Dimension (UISegmentedControl) - Will support soon
      • Pair Threshold (UISlider)
      • NMS Filter Size (UIStepper)
      • Maximum Number Of Person (UIStepper) - Will support soon
  • Separate Int, Float, Float? extensions to Numeric.swift

Storyboard

StillImageLineViewController LiveImageViewController

@tucan9389 tucan9389 requested a review from syjdev May 4, 2020 04:20
@tucan9389 tucan9389 self-assigned this May 4, 2020
tucan9389
tucan9389 commented May 4, 2020
View reviewed changes
PoseEstimation-TFLiteSwift/TFLiteImageInterpreter.swift
self.accelerator = accelerator
#endif
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this line, #49 will be solved.

@tucan9389 tucan9389 linked an issue May 4, 2020 that may be closed by this pull request
Cannot inference with GPU on simulator (Xcode Version 11.4.1 (11E503a)) #49
Open
@tucan9389 tucan9389 mentioned this pull request May 5, 2020
Merged
MBKwon
MBKwon reviewed May 5, 2020
View reviewed changes
PoseEstimation-TFLiteSwift/StillImageLineViewController.swift Outdated
}

@IBAction func didChangeDimension(_ sender: UISegmentedControl) {
// NOT SUPPORT YET
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if It will be implemented, It is better using todo comment. It is easy to track the unimplemented codes.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBKwon

Did you mean // TODO annotation? I agree. Thank you for your feedback.

@tucan9389 tucan9389 merged commit 8cddd2f into multi-pose-on-liveimagevc May 9, 2020
@tucan9389 tucan9389 deleted the param-ui branch May 9, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBKwon MBKwon MBKwon left review comments

@syjdev syjdev Awaiting requested review from syjdev

Assignees

@tucan9389 tucan9389

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot inference with GPU on simulator (Xcode Version 11.4.1 (11E503a))
2 participants
@tucan9389 @MBKwon