Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Support multi pose estimation on LiveImageViewController #44

Merged
merged 13 commits into from
May 9, 2020

Conversation

tucan9389
Copy link
Owner

@tucan9389 tucan9389 commented May 1, 2020

PR Points

  • Support OpenPose on LiveImageViewController
  • Can select visible part on LiveImageViewController with UIButtons

Demo

@tucan9389 tucan9389 self-assigned this May 1, 2020
@tucan9389 tucan9389 requested a review from syjdev May 1, 2020 07:29
var selectedPartName: String = "ALL"
var selectedPartIndex: Int? {
guard let partName = selectedPartName.components(separatedBy: "(").first else { return nil }
return partIndexes[partName]
Copy link

@MBKwon MBKwon May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

‘Indices’ is a plural of index. indexes is not a plural.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBKwon

Here is similar discuss #41 (comment)

Apple's official document and API use the indices, but indexes have been also used (link). So I think I can also use the indexes name. Do you have any opinion about it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can’t find ‘indexes’ in the link you provide.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see the discussion in the following link.

Here is the screenshot.

image

If you cannot find it with the above link, please tell me again.

Thank you.

Copy link

@MBKwon MBKwon May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found about it. You can use both of them. But they have some differences. You choose what you want to use after you see the below.

https://www.nasdaq.com/articles/indexes-or-indices-whats-the-deal-2016-05-12

Copy link
Owner Author

@tucan9389 tucan9389 May 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MBKwon

When I googled, there were two terms of meaning. Indices have been used in mathematical(Figure 1), and Indexes have been used in publishing(Figure 2). In this context, Indexes is more fit but I think there is no precise answer about the subject[3].

So I'll use the indexes in this repository. If you have any other opinions, please comment feel free.

Figure 1. Index of mathematic[1]
Figure 2. Index of publishing[2]

[1] https://images.app.goo.gl/ot6ytTzGaKxsg16x8
[2] https://images.app.goo.gl/a4owkwwa1yQ6gWXA6
[3] https://stackoverflow.com/a/1379069/4160632

@tucan9389 tucan9389 merged commit 238c176 into feature/multi-pose May 9, 2020
@tucan9389 tucan9389 deleted the multi-pose-on-liveimagevc branch May 9, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants