-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR] Support multi pose estimation on LiveImageViewController #44
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c8ace45
Support multi pose estimation on LiveImageViewController
tucan9389 8b37831
Merge commit '98d29ba813425a33ca1e994b415fc74e4e79e70a' into multi-po…
tucan9389 dc101b9
Support multi pose estimation and can select visible part on LiveImag…
tucan9389 7ed9c71
Change point of configuring post-process param
tucan9389 d8d29d6
Add ui control for configuring post processing param (#47)
tucan9389 ac2b7f5
Add PreprocessOptions and PostprocessOptions and connect method on ui…
tucan9389 49d420a
Add single or multi selectable segment control on StillImageLineViewC…
tucan9389 73b2a1f
Support to export overlay view on StillImageLineViewController and St…
tucan9389 aef128f
Get directory path safely
tucan9389 accf554
Get directory path safely
tucan9389 e50ec36
Change todo comments
tucan9389 1393930
Merge pull request #54 from tucan9389/export-overlayview-image
tucan9389 8cddd2f
Merge pull request #50 from tucan9389/param-ui
tucan9389 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1,453 changes: 1,250 additions & 203 deletions
1,453
PoseEstimation-TFLiteSwift/Base.lproj/Main.storyboard
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
// | ||
// NumericExtension.swift | ||
// PoseEstimation-TFLiteSwift | ||
// | ||
// Created by Doyoung Gwak on 2020/05/03. | ||
// Copyright © 2020 Doyoung Gwak. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
|
||
extension Optional where Wrapped == Float { | ||
var labelString: String { | ||
guard let value = self else { return "nil" } | ||
return String(format: "%.2f", value) | ||
} | ||
} | ||
|
||
extension Float32 { | ||
func string(_ format: String = "%.2f") -> String { | ||
return String(format: format, self) | ||
} | ||
} | ||
|
||
extension Optional where Wrapped == Float { | ||
static func *(lhs: Wrapped?, rhs: Float) -> Self { | ||
guard let lhs = lhs else { return nil } | ||
return some(lhs * rhs) | ||
} | ||
} | ||
|
||
extension Int { | ||
var labelString: String { | ||
return String(format: "%d", self) | ||
} | ||
} | ||
|
||
extension Optional where Wrapped == Int { | ||
var labelString: String { | ||
guard let value = self else { return "nil" } | ||
return value.labelString | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
‘Indices’ is a plural of index. indexes is not a plural.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MBKwon
Here is similar discuss #41 (comment)
Apple's official document and API use the
indices
, butindexes
have been also used (link). So I think I can also use theindexes
name. Do you have any opinion about it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can’t find ‘indexes’ in the link you provide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can see the discussion in the following link.
Here is the screenshot.
If you cannot find it with the above link, please tell me again.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found about it. You can use both of them. But they have some differences. You choose what you want to use after you see the below.
https://www.nasdaq.com/articles/indexes-or-indices-whats-the-deal-2016-05-12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MBKwon
When I googled, there were two terms of meaning.
Indices
have been used in mathematical(Figure 1), andIndexes
have been used in publishing(Figure 2). In this context,Indexes
is more fit but I think there is no precise answer about the subject[3].So I'll use the
indexes
in this repository. If you have any other opinions, please comment feel free.[1] https://images.app.goo.gl/ot6ytTzGaKxsg16x8
[2] https://images.app.goo.gl/a4owkwwa1yQ6gWXA6
[3] https://stackoverflow.com/a/1379069/4160632