-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR] Drawing heatmap for model debugging #41
Conversation
…ose's PAF and rename some class name
|
||
class PoseConfidenceMapDrawingView: UIView { | ||
typealias CGLine = (from: CGPoint, to: CGPoint) | ||
var outputChannelIndexes: [Int] = [0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indexes (x)
Indices (o)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indexes
also correct on the meaning view, but I'll accept your suggestion in the technical view.
} | ||
} | ||
|
||
func drawRect(with rect: CGRect, value: Float32 = 0.0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'value' is so abstract name.
I recommend to pass UIColor to drawRect function instead (value: Float32).
drawRect function have to no idea about DrawingConstant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be changed to alpha
, confidence
, or score
.
Thanks for your opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@syjdev
I changed to componentOfVector
🙂
} | ||
|
||
private extension CGPoint { | ||
func scaled(to ratioSize: CGSize) -> CGPoint { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think,
This function's behavior mean 'coordinate move'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term scale
was used in affine transformation.
I think coordinate move
corresponds to transform
.
ref: https://neutrium.net/mathematics/basics-of-affine-transformation/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Good,
I got the fact.
thx.
Related Issue
Summary
PR Points
StillImageViewController
→StillImageLineViewController
StillImageHeatmapViewController
PoseConfidenceMapDrawingView
PoseEstimator
protocolpairNames
propertyoutputs
propertyTFLiteFlatArray
struct type to class type