[PR] Drawing heatmap for model debugging #41
Conversation
…ose's PAF and rename some class name
|
|
||
| class PoseConfidenceMapDrawingView: UIView { | ||
| typealias CGLine = (from: CGPoint, to: CGPoint) | ||
| var outputChannelIndexes: [Int] = [0] |
There was a problem hiding this comment.
indexes also correct on the meaning view, but I'll accept your suggestion in the technical view.
| } | ||
| } | ||
|
|
||
| func drawRect(with rect: CGRect, value: Float32 = 0.0) { |
There was a problem hiding this comment.
'value' is so abstract name.
I recommend to pass UIColor to drawRect function instead (value: Float32).
drawRect function have to no idea about DrawingConstant.
There was a problem hiding this comment.
It could be changed to alpha, confidence, or score.
Thanks for your opinion.
There was a problem hiding this comment.
@syjdev
I changed to componentOfVector 🙂
| } | ||
|
|
||
| private extension CGPoint { | ||
| func scaled(to ratioSize: CGSize) -> CGPoint { |
There was a problem hiding this comment.
I think,
This function's behavior mean 'coordinate move'.
There was a problem hiding this comment.
The term scale was used in affine transformation.
I think coordinate move corresponds to transform.
ref: https://neutrium.net/mathematics/basics-of-affine-transformation/
There was a problem hiding this comment.
👍
Good,
I got the fact.
thx.
Related Issue
Summary
PR Points
StillImageViewController→StillImageLineViewControllerStillImageHeatmapViewControllerPoseConfidenceMapDrawingViewPoseEstimatorprotocolpairNamespropertyoutputspropertyTFLiteFlatArraystruct type to class type