Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add common dimensions and tag dimensions to AWS Compliance Mod #574

Merged
merged 36 commits into from
Mar 22, 2023
Merged

Add common dimensions and tag dimensions to AWS Compliance Mod #574

merged 36 commits into from
Mar 22, 2023

Conversation

madhushreeray30
Copy link
Contributor

Checklist

  • Issue(s) linked

khushboo9024 and others added 13 commits March 6, 2023 12:10
@madhushreeray30 madhushreeray30 self-assigned this Mar 8, 2023
@madhushreeray30 madhushreeray30 marked this pull request as draft March 8, 2023 15:44
@madhushreeray30 madhushreeray30 changed the title Add common dimensions to AWS Compliance Mod (Conformance Pack) Add common dimensions to AWS Compliance Mod Mar 15, 2023
@rajlearner17 rajlearner17 marked this pull request as ready for review March 15, 2023 13:10
@madhushreeray30 madhushreeray30 changed the title Add common dimensions to AWS Compliance Mod Add common dimensions and tag dimensions to AWS Compliance Mod Mar 15, 2023
rajlearner17
rajlearner17 reviewed Mar 15, 2023
View reviewed changes
conformance_pack/ssm.sp Outdated
else c.resource_id || ' patch ' || c.title || ' is non-compliant.'
end as reason
-- Additional Dimensions
${local.tag_dimensions_sql}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madhushreeray30 ${local.tag_dimensions_sql} should not be here, as the respective tables not supporting tags. Pls check below outcome when executed with tag_dimensions in spvars

| + 2 All EC2 instances managed by Systems Manager should be compliant with patching requirements ............................................................. HIGH     1 /     1 [=         ]
| | 
| | ERROR: column "tags" does not exist (SQLSTATE 42703)
| | 
| + 3 Instances managed by Systems Manager should have an association compliance status of COMPLIANT ...............................................................     1 /     1 [=         ]
|   
|   ERROR: column "tags" does not exist (SQLSTATE 42703)
|

@rajlearner17 rajlearner17 linked an issue Mar 17, 2023 that may be closed by this pull request
Add common and tag dimensions across compliance queries #584
Closed
@misraved
Copy link
Contributor

@khushboo9024 could you please update the docs/index.md file to include information on common and tag dimensions? Please use https://github.com/turbot/steampipe-mod-aws-thrifty/blob/main/docs/index.md#common-and-tag-dimensions for reference.

@misraved misraved merged commit 1bbc45c into release/v0.58 Mar 22, 2023
@misraved misraved deleted the staging/v0.58 branch March 22, 2023 13:25
@misraved misraved mentioned this pull request Mar 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajlearner17 rajlearner17 rajlearner17 left review comments

@khushboo9024 khushboo9024 khushboo9024 left review comments

@misraved misraved misraved approved these changes

Assignees

@madhushreeray30 madhushreeray30

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add common and tag dimensions across compliance queries
4 participants
@madhushreeray30 @misraved @rajlearner17 @khushboo9024