Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove X-UA-Compatible from starter template as it is deprecated in IE11. #21476

Closed
IamManchanda opened this issue Dec 30, 2016 · 2 comments
Closed

Comments

@IamManchanda
Copy link

IamManchanda commented Dec 30, 2016

With dropping of IE9,
I think there is no need now for the below code so please remove this from starter template
<meta http-equiv="X-UA-Compatible" content="IE=Edge">

Source: http://stackoverflow.com/a/6771584
( Same link that @mdo posted in his codeguide )

Here are the important quotes to consider from this comment

Depending upon what Microsoft browsers you support you may not need to continue using the X-UA-Compatible tag. If you need to support IE 9 or IE 8, then I would recommend using the tag. If you only support the latest browsers (IE 11 and/or Edge) then I would consider dropping this tag altogether.

ie-edge

@bardiharborow bardiharborow changed the title Remove IE-EDGE from starter template as not required now ( Flexbox only, IE9 Drop ) Remove X-UA-Compatible from starter template as it is deprecated in IE11. Dec 31, 2016
@bardiharborow
Copy link
Member

bardiharborow commented Dec 31, 2016

IE 10 will default to edge mode regardless of this directive if used with a HTML5 doctype, except in certain circumstances (intranet sites). I suspect that we left most of the enviroments where such circumstances exist behind when we dropped IE9. In IE11, "document modes are deprecated and should no longer be used".

@IamManchanda
Copy link
Author

IamManchanda commented Dec 31, 2016

Yup @bardiharborow . This might be a bold move for some but this should be taken as we should remove any crutches behind which are of no use for the new, modern and flexibile web !!!

@mdo mdo added this to the v4.0.0-alpha.6 milestone Dec 31, 2016
@mdo mdo added the has-pr label Dec 31, 2016
fedarko added a commit to marbl/MetagenomeScope that referenced this issue Nov 29, 2018
See twbs/bootstrap#21476 and
https://stackoverflow.com/q/6771258 for a thorough overview.

From the looks of it, this tag isn't needed for IE 10+, and IE 10
is the oldest version of IE that the dependencies of the viewer
interface support as of writing (per
https://github.com/farbelous/bootstrap-colorpicker/issues/271).

So there's no need to include this tag.

Also for posterity here's a list of all of the IE version support
for the viewer interface's current dependencies (I was going to
include this in a comment in the viewer interface that justified
keeping the tag in, but then I realized that this tag wasn't even
needed for IE 10 so I scrapped the comment) --

d3 v4: IE9+
    (https://github.com/d3/d3/wiki#supported-environments)
Cytoscape.js: IE9+ [supports canvas and most of ECMAScript 5]
    (http://js.cytoscape.org/#introduction/factsheet)
jQuery: IE9+
    (https://jquery.com/browser-support/)
bootstrap 3: IE 8-11
    (https://getbootstrap.com/docs/3.3/getting-started/#support)
bootstrap colorpicker: IE >= 10
    (https://github.com/farbelous/bootstrap-colorpicker/issues/271)

Couldn't find much data on sql.js browser support aside from that
old browsers probably aren't a good idea with it, so using IE
in general with sql.js is probably not feasible. (See:
https://github.com/kripken/sql.js/issues/238,
https://github.com/kripken/sql.js/issues/239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants