Skip to content

Commit

Permalink
Remove unneeded IE compatibility <meta> tag
Browse files Browse the repository at this point in the history
See twbs/bootstrap#21476 and
https://stackoverflow.com/q/6771258 for a thorough overview.

From the looks of it, this tag isn't needed for IE 10+, and IE 10
is the oldest version of IE that the dependencies of the viewer
interface support as of writing (per
https://github.com/farbelous/bootstrap-colorpicker/issues/271).

So there's no need to include this tag.

Also for posterity here's a list of all of the IE version support
for the viewer interface's current dependencies (I was going to
include this in a comment in the viewer interface that justified
keeping the tag in, but then I realized that this tag wasn't even
needed for IE 10 so I scrapped the comment) --

d3 v4: IE9+
    (https://github.com/d3/d3/wiki#supported-environments)
Cytoscape.js: IE9+ [supports canvas and most of ECMAScript 5]
    (http://js.cytoscape.org/#introduction/factsheet)
jQuery: IE9+
    (https://jquery.com/browser-support/)
bootstrap 3: IE 8-11
    (https://getbootstrap.com/docs/3.3/getting-started/#support)
bootstrap colorpicker: IE >= 10
    (https://github.com/farbelous/bootstrap-colorpicker/issues/271)

Couldn't find much data on sql.js browser support aside from that
old browsers probably aren't a good idea with it, so using IE
in general with sql.js is probably not feasible. (See:
https://github.com/kripken/sql.js/issues/238,
https://github.com/kripken/sql.js/issues/239)
  • Loading branch information
fedarko committed Nov 29, 2018
1 parent ef40a30 commit 6459512
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion electron/index.min.html

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion viewer/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta name="viewport"
content="width=device-width,initial-scale=1,user-scalable=no" />
<meta name="description"
Expand Down
2 changes: 1 addition & 1 deletion viewer/index.min.html

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion viewer/webstrates_index.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta name="viewport"
content="width=device-width,initial-scale=1,user-scalable=no" />
<meta name="description"
Expand Down

0 comments on commit 6459512

Please sign in to comment.