Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport JS unit test fixes from v4 #20259

Merged
merged 2 commits into from
Jul 8, 2016
Merged

Backport JS unit test fixes from v4 #20259

merged 2 commits into from
Jul 8, 2016

Conversation

cvrebert
Copy link
Collaborator

@cvrebert cvrebert commented Jul 8, 2016

Refs #16834.

@dmethvin @cvrebert
Port #20190 to v3
4a8b29f 
Scrollspy test: Allow for async .then() in jQuery 3; fixes #20182

Instead of doing a new assert.async(), just do a single one for the entire test
and let the .then() be async as well.
@dmethvin @cvrebert
Port #20198 to v3
bc05ef1 
ScrollSpy unit test: Use single done() in a then() instead of multiple done()s

Fixes test flakiness on OS X Safari and Android when using jQuery 3.
Fixes #20182 more
Refs #20191
@cvrebert cvrebert added this to the v3.3.7 milestone Jul 8, 2016
@cvrebert cvrebert merged commit 415f144 into master Jul 8, 2016
@cvrebert cvrebert deleted the backport-unit-fixes branch July 8, 2016 06:51
@mdo mdo mentioned this pull request Jul 25, 2016
Closed
This was referenced Mar 12, 2021
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
js v3
Projects
None yet
Milestone
v3.3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@cvrebert @dmethvin