V4 without jquery: workaround for ms edge defaultPrevented reset #23989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
reviewed
Sep 19, 2017
js/src/dom/eventHandler.js
Outdated
| @@ -23,6 +23,19 @@ const workingDefaultPrevented = (() => { | |||
| return e.defaultPrevented | |||
| })() | |||
|
|
|||
| const defaultPreventedPreservedOnDispatch = typeof window.CustomEvent !== 'function' || (() => { | |||
There was a problem hiding this comment.
to avoid double check of typeof window.CustomEvent you should move this IIFE where we add a polyfill to add CustomEvent
There was a problem hiding this comment.
and can you add a comment to explain the reason we added that please
|
Thank you to handled that @alekitto ❤️ |
alekitto
force-pushed
the
v4-without-jquery
branch
from
c280dec
to
d88fda8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #23586 (comment) and https://saucelabs.com/jobs/03afada422c7448d84ea067dee18906d failed job
Workaround for M$ Edge resetting defaultPrevented flag on dispatchEvent
@Johann-S I will really appreciate your opinion about this