-
-
Notifications
You must be signed in to change notification settings - Fork 78.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5 without jQuery #23586
v5 without jQuery #23586
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b6f70b2
to
8f63c2e
Compare
Will there be both a jQuery and a non-jQuery version? If you're using libraries that require jQuery, you can use the jQuery version, and if not, the non-jQuery one. |
We will have only one release without jQuery but if we detect jQuery you'll be able to use Bootstrap's plugin as before 👍 |
8f63c2e
to
53f5fc0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
99d47ac
to
371e721
Compare
c1afd86
to
9d8fa89
Compare
If you are interested in Vanilla JS versions of tooltip, popover, and scrollspy, We have versions that we use in Bootstrap-Vue v1.0.0.beta.7 (see in action at docs)
We have a few extra features added to Tooltips and popovers (such as a new PR bootstrap-vue/bootstrap-vue#1024 also includes much of the regular modal.js functionality in Vanilla JS format (although tweaked for use with Vue.js) |
thanks @tmorehouse we will take a look 👍 |
@Johann-S no problem. There are only a few Vue.js centric items in the tooltip/popover classes (such as event emitting) |
9d8fa89
to
6717d36
Compare
Boostrap-Vue is quite interested in the jQuery free version of some of the plugins, as we might be able to direclty import some of these modues (or the classes), to replace some of our code. We have just finished porting ScrollSpy over to vanilla js (with some helper dom functions we have created). If you like, I could see if I can port our vanilla version to this branch as a PR (the main things to change would be the event signatures) |
Sure @tmorehouse this branch is open to everyone who wants to help us 👍 |
OK, I ill try porting over in the next few days. |
6e49940
to
ef8a002
Compare
@alekitto it seems we have issue on IE with your last commit see : https://saucelabs.com/beta/tests/af6abf5c5275433080920e7f34a234cc/commands#12 and https://travis-ci.org/twbs/bootstrap/jobs/276457805#L718 |
@alekitto it's still failed on Edge see : |
@Johann-S It seems that MSEdge resets the |
a292747
to
542de5d
Compare
Boom! Awesome work! 🎉 |
Thanks to everyone! I hope we didn't break a lot of things, we tried our best. That being said, please try the master branch and feel free to provide any doc tweaks or bugfixes. We'll make a new issue with the remaining TODO tomorrow. |
Special thanks to @alekitto which helped me a lot to rewrite our plugins 👍 |
Woohoo, well done y'all! <3 |
Nice job! |
Is this going to v5? |
Finally...waiting for it since very long. Thanks a lot everyone. |
Congratulations, great job. I'm doing tests and I see that the branch "v5-dev-jo-eslint-airbnb" directly import plugins individually of v5-dev-jo-eslint-airbnb/src/js/ works without jquery in v4-dev, the question is if this is going to join the master. If this will only be available in v5, it is safe to copy the javascript files to v4. |
Can't wait. Thank you Bootstrap team! 😄 |
Is it safe to use this 4.3.1 without jQuery in production? Or better to wait. Sorry if it's an idiot question, I just came on this PR discussion, and accordingly to: We can use it already! No more jquery requirement |
From what I have read, Bootstrap without jQuery has been pushed to v5, so you will need to wait until it launches. Seems that v4 will still use jQuery. v5 is not scheduled, but seeing by the PRs, it may come this year at best as long there is constant work on it. |
You shouldn't use something which is in development on production, however dangerous it might be. That being said, you can always experiment with the master branch. Just keep in mind, it's not done yet. |
Plugins:
Tests:
Data
in our unit tests (Remove the use of Data and EventHandler in our unit tests #26685)EventHandler
in our unit tests (Remove the use of Data and EventHandler in our unit tests #26685)Build:
const
orlet
in the dist files. (bootstrap.js)Docs:
Update plugin pages
$()
$()
Other doc pages
Stop using jQuery
Update
/getting-started/browsers-devices/
and remove any IE referencesAdd a section explaining that it's possible to use this version with and without jQuery
Search docs for
jquery
(not case sensitive) and$(
Replace https://codepen.io/Johann-S/pen/djJYPb or add a codepen with vanilla JS
Maybe explain when an element is considered visible in the scrollspy callout
Browser compatibility:
Various
Util.TRANSITION_END
?DOMContentLoaded
anymore in tests and docs.Demo:
https://deploy-preview-23586--twbs-bootstrap.netlify.com/
If you want to help us do not hesitate to create a PR which targets this branch
v4-without-jquery
.