Rewritten scrollspy without jquery #24879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Johann-S any news on this? |
Johann-S
force-pushed
the
v4-without-jquery
branch
2 times, most recently
from
85aac97
to
db527f9
Compare
|
@alekitto can you rebase please ? |
alekitto
force-pushed
the
scrollspy-without-jquery
branch
from
2348dec
to
5899e18
Compare
|
@Johann-S done, but I can't test it on IE at the moment |
|
Did you take a look to our coverage code on the scrollspy plugin ? Is it greater than 80% ? |
|
Coverage reports 84.8% of lines covered |
|
Thank you @alekitto 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #23586