update alert documentation without jquery #27062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
force-pushed
the
v4-without-jquery-doc
branch
from
5a664f2
to
bd25b32
Compare
vsn4ik
reviewed
Aug 16, 2018
| @@ -76,7 +76,10 @@ You can see this in action with a live demo: | |||
| Enable dismissal of an alert via JavaScript: | |||
|
|
|||
| {% highlight js %} | |||
| $('.alert').alert() | |||
| var alertList = document.querySelectorAll('.alert') | |||
| alertList.forEach(function (alert) { | |||
There was a problem hiding this comment.
Maybe
var alertList = document.querySelectorAll('.alert')
Array.from(alertList).forEach(...);?
There was a problem hiding this comment.
Array.from isn't widely supported and we can use forEach on NodeList so I won't change this line but thank you for your feedback @vsn4ik it's always appreciated 😉
XhmikosR
approved these changes
Aug 16, 2018
|
@Johann-S: feel free to squash and merge when tests pass. |
|
@XhmikosR test won't pas unfortunately 😢 because for an unknown reason they fail on Sauce Labs but they works very well on my computer, do you have the time to check that on your computer ? |
Johann-S
added a commit
that referenced
this pull request
Aug 31, 2018
Johann-S
added a commit
that referenced
this pull request
Nov 8, 2018
Johann-S
added a commit
that referenced
this pull request
Nov 9, 2018
Johann-S
added a commit
that referenced
this pull request
Nov 14, 2018
XhmikosR
pushed a commit
that referenced
this pull request
Nov 18, 2018
XhmikosR
pushed a commit
that referenced
this pull request
Nov 20, 2018
XhmikosR
pushed a commit
that referenced
this pull request
Nov 20, 2018
XhmikosR
pushed a commit
that referenced
this pull request
Nov 21, 2018
XhmikosR
pushed a commit
that referenced
this pull request
Nov 22, 2018
Johann-S
added a commit
that referenced
this pull request
Nov 25, 2018
Johann-S
added a commit
that referenced
this pull request
Nov 27, 2018
XhmikosR
pushed a commit
that referenced
this pull request
Nov 28, 2018
Johann-S
added a commit
that referenced
this pull request
Nov 29, 2018
Johann-S
added a commit
that referenced
this pull request
Nov 29, 2018
Johann-S
added a commit
that referenced
this pull request
Jan 4, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Jan 6, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Jan 7, 2019
Johann-S
added a commit
that referenced
this pull request
Jan 17, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Jan 17, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Feb 7, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Feb 7, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Feb 8, 2019
Johann-S
added a commit
that referenced
this pull request
Feb 11, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Feb 12, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Feb 13, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Feb 15, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Feb 16, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Feb 19, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite our alert page documentation without the use of jQuery