Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update alert documentation without jquery #27062

Merged
merged 3 commits into from
Aug 24, 2018

Conversation

Johann-S
Copy link
Member

Rewrite our alert page documentation without the use of jQuery

@@ -76,7 +76,10 @@ You can see this in action with a live demo:
Enable dismissal of an alert via JavaScript:

{% highlight js %}
$('.alert').alert()
var alertList = document.querySelectorAll('.alert')
alertList.forEach(function (alert) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe

var alertList = document.querySelectorAll('.alert')
Array.from(alertList).forEach(...);

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array.from isn't widely supported and we can use forEach on NodeList so I won't change this line but thank you for your feedback @vsn4ik it's always appreciated 😉

@XhmikosR
Copy link
Member

@Johann-S: feel free to squash and merge when tests pass.

@Johann-S
Copy link
Member Author

@XhmikosR test won't pas unfortunately 😢 because for an unknown reason they fail on Sauce Labs but they works very well on my computer, do you have the time to check that on your computer ?

@Johann-S Johann-S merged commit 8cb6ced into v4-without-jquery Aug 24, 2018
@Johann-S Johann-S deleted the v4-without-jquery-doc branch August 24, 2018 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants