Add back cursor: pointer for .btn-link #23995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suggest that there's no longer a need to include the section on workaround for the IE10 bug on Windows Phone 8. Not only was this bug patched in a later release of Windows Phone 8 (which shipped in 2013), but Windows Phone 8's support ended a long time ago - even its successor Windows Phone 8.1 is no longer supported by Microsoft. The potential audience affected by this bug is likely microscopic so I suggest it can be safely removed. I suggest the workaround JS (http://getbootstrap.com/assets/js/ie10-viewport-bug-workaround.js) can also be safely removed from the docs and examples but I haven't done that in this PR.
Pretty useless, we need to switch to the official HTML validator ASAP.
Fix HTML errors
Feather link didn't go anywhere. Changed feather link from `colebemis.com/feather` to `feathericons.com`
Also: * compress them with SVGOMG * add titles * add `focusable="false"`
When one uses say a carousel inside a tab, the `.active` selector previously matches the carousel ones too leading to broken tabs. It's not the perfect solution but should the job for now.
tabs: fix nested tabs.
Before: 354 KB (363.514 bytes) After: 129 KB (132.748 bytes)
.table-info should be .info in bootstrap 3
Fix(docs): duplicate class in navbar docs
Structure examples with appropriate `<main>`, `<header>`, `<footer>`
to fix the images
Album example: fix holder.js calls
…'s inside nav-item's (#23967) * fix(scrollspy): Handle nested navs when nav-link inside nav-item * [scrolspy] Find only child .nav-link's inside .nav-item * [scrollspyt] Add tests for nested navs with nav-link inside nav-item * fix troy-o's in test
232e86d makes total sense but buttons with class `.btn-link` should still display a cursor.
houndci-bot
reviewed
Sep 18, 2017
| @@ -0,0 +1,56 @@ | |||
| /*! | |||
|
CONTRIBUTING.md said to open PRs against master. If I should PR against v4-dev instead, let me know. |
|
I did all my PRs which got accepted against |
|
@jeffbowen Do it to |
|
yes please open it on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
232e86d makes total sense but buttons with class
.btn-linkshould still display a cursor.