Refactor a few selectors. #24404
Refactor a few selectors. #24404
Conversation
XhmikosR
commented
Oct 17, 2017
•
XhmikosR
commented
- move a couple of them before the more specific ones.
- change nesting to be under the same parent selector
- use the ampersand more
1. move a couple of them before the more specific ones. 2. change nesting to be under the same parent selector 3. use the ampersand more
…no-descending-specificity
assets/scss/_component-examples.scss
Outdated
| h4, | ||
| h5, | ||
| h6 { | ||
| margin: 0; |
There was a problem hiding this comment.
I think we can change this to margin-top: 0; and margin-bottom: 0;. Can't imagine we're adding horizontal margin to any headings.
| &.fade .modal-dialog { | ||
| @include transition($modal-transition); | ||
| transform: translate(0, -25%); | ||
| .modal-open & { |
There was a problem hiding this comment.
In general I'm not a fan of this type of nesting—usually ends up more difficult to parse in more complicated rulesets.
There was a problem hiding this comment.
I think we need to keep this; it doesn't complicate things a lot and along with the complexity rule we should be fine. I plan to enable that later too.
I removed the & & instances.
scss/_code.scss
Outdated
| @@ -31,7 +31,7 @@ kbd { | |||
| @include border-radius($border-radius-sm); | |||
| @include box-shadow($kbd-box-shadow); | |||
|
|
|||
| kbd { | |||
| & & { | |||
There was a problem hiding this comment.
This is weird at first, but probably fine.
There was a problem hiding this comment.
@XhmikosR sorry that I couldn't help much with this one. Thanks for doing it. You made a linter happy :)
|
@andresgalante: this isn't quite ready since I haven't enabled the rule yet. Still waiting for your patch so that we enable the rule. :) |
|
:p lol I thought it was! ok I'll continue with it |
XhmikosR
changed the title
no-descending-specificity rule
|
@andresgalante: I'm gonna merge this as is, and we should tackle the 2 remaining stylelint rules later. |
