-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor a few selectors. #24404
Merged
Merged
Refactor a few selectors. #24404
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a0005f7
Refactor a few selectors.
XhmikosR 6c580bc
Merge remote-tracking branch 'remotes/origin/v4-dev' into v4-dev-xmr-…
XhmikosR f160f34
Update _component-examples.scss
XhmikosR 715f693
Update _breadcrumb.scss
XhmikosR cc9da79
Update _code.scss
XhmikosR 6c3cb29
Update _buttons.scss
XhmikosR 97b486b
Update _tables.scss
XhmikosR 7dc2d9c
Update _breadcrumb.scss
XhmikosR 8fd794a
Update _buttons.scss
XhmikosR 1071175
Merge branch 'v4-dev' into v4-dev-xmr-no-descending-specificity
XhmikosR 403690f
Merge branch 'v4-dev' into v4-dev-xmr-no-descending-specificity
XhmikosR 87c758b
Merge branch 'v4-dev' into v4-dev-xmr-no-descending-specificity
XhmikosR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I'm not a fan of this type of nesting—usually ends up more difficult to parse in more complicated rulesets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to keep this; it doesn't complicate things a lot and along with the complexity rule we should be fine. I plan to enable that later too.
I removed the
& &
instances.