-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure to increase contrasts on buttons & colored links hover/active states #30989
Conversation
f43e0db
to
f564fe4
Compare
will this also apply to the toggle buttons https://v5.getbootstrap.com/docs/5.0/forms/checks/#toggle-buttons ? in particular, i find the outline styles ones confusing when hovering with the mouse, as at that point you can't tell at all whether the toggle is on or off https://v5.getbootstrap.com/docs/5.0/forms/checks/#outlined-styles - likely, we'd need a separate hover style for non-toggled buttons (probably one that is still outlined, rather than filled, so that the toggle state is visually clear on hover) |
@patrickhlauke This PR bascially only choose between So it'll apply to toggle buttons, but won't improve what you're talking about, I guess. |
no worries, i'll file a separate issue then :) |
posted the separate issue here #31149 |
This was merged wrong it seems. |
…states (twbs#30989) * feat(buttons): ensure to increase contrasts on hover/active * Update _buttons.scss Co-authored-by: XhmikosR <xhmikosr@gmail.com> Co-authored-by: Mark Otto <markd.otto@gmail.com>
Alongside #30972 — and in #30548 roadmap — this ensures that hover and active states have higher contrasts than the default state:
Preview: Buttons — Colored links
Since this is only visual, should we consider to backport this to v4?