-
-
Notifications
You must be signed in to change notification settings - Fork 78.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure to pass 4.5:1 contrast ratio everywhere #30548
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 10, 2020
This PR itself can now tackle insufficient contrasts through our codebase and docs, now that #31276 bumped |
Closed
@ffoodd is this still valid or can we close it? |
We can close it. If we're still missing some contrast out there, we'll tackle it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sounds like dependabot one, but isn't :)
Paving the way in #30468 — and to keep going with #29315 : my goal is to make this happen after tackling every obstacles.
To solve before the bump
Those should probably adressed separately, consider this as a roadmap to enlightment :D
.btn-success:hover
case mentionned in #30468 (comment);color-level()
,lighten()
anddarken()
seem misused: either on:hover
for buttons (always darken) or to definecolor
andbackground-color
with the same level, no matter what the base color is (eg..alert-light
seems wrong) — there's probably room to improvement by usingtint()
andshade()
here;*-bg-level
and*-border-level
variables #30487$dark
to$gray-900
#30550 →.text-info
,.text-black-50
and.text-white-50
can't make it to 4.5:1 — however, using$gray-900
instead of$gray-800
for$dark
would solve this (and several other dark-ish things with insufficient contrasts);.text-muted
or.disabled
things;.btn-outline-*
and.link-*
examples should be shown with dark background:Merging this would be a kind of consecration 🎉
Fixes #25126