Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure to pass 4.5:1 contrast ratio everywhere #30548

Closed
wants to merge 6 commits into from

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Apr 10, 2020

Sounds like dependabot one, but isn't :)

Paving the way in #30468 — and to keep going with #29315 : my goal is to make this happen after tackling every obstacles.

To solve before the bump

Those should probably adressed separately, consider this as a roadmap to enlightment :D

Merging this would be a kind of consecration 🎉

Fixes #25126

@ffoodd ffoodd changed the title Bump $min-contrast-ratio to 4.5 Ensure to pass 4.5:1 contrast ratio everywhere Jul 15, 2020
@ffoodd
Copy link
Member Author

ffoodd commented Jul 15, 2020

This PR itself can now tackle insufficient contrasts through our codebase and docs, now that #31276 bumped $min-contrast-ratio to 4.5 🎉

@XhmikosR
Copy link
Member

@ffoodd is this still valid or can we close it?

@ffoodd
Copy link
Member Author

ffoodd commented Oct 21, 2020

We can close it. If we're still missing some contrast out there, we'll tackle it later.

@ffoodd ffoodd closed this Oct 21, 2020
@ffoodd ffoodd deleted the master-fod-4.5-min-contrast-ratio branch October 21, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color combinations that fail WCAG 2 AA 4.5:1 contrast ratio
2 participants