Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5: Tweak some colors #31276

Merged
merged 5 commits into from
Jul 13, 2020
Merged

v5: Tweak some colors #31276

merged 5 commits into from
Jul 13, 2020

Conversation

mdo
Copy link
Member

@mdo mdo commented Jul 10, 2020

Attempts to make green and cyan more accessible. Here's current/old and the new from this PR:

old

new

You'll also note I was playing with some padding and border-radius here. Might still share that soon.

@mdo mdo requested a review from a team as a code owner July 10, 2020 22:58
@patrickhlauke
Copy link
Member

could also go the other way with the green, with black text and something like #43CB62 ?

i like the cyan

Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat!

@XhmikosR
Copy link
Member

I think we should mention the change in migration and assuming everyone is fine with the new green it should be good to go :)

Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♥️

@XhmikosR XhmikosR merged commit 6914efe into main Jul 13, 2020
@XhmikosR XhmikosR deleted the color-tweaks branch July 13, 2020 18:23
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
* Tweak green and cyan colors, bump min contrast ratio to 4.5

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants