Fix another Sass division #34332
Merged
Fix another Sass division #34332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpadev
reviewed
Jun 22, 2021
| @@ -29,7 +29,7 @@ | |||
| @mixin make-col($size: false, $columns: $grid-columns) { | |||
| @if $size { | |||
| flex: 0 0 auto; | |||
| width: divide(100%, divide($columns, $size)); | |||
| width: percentage(divide($size, $columns)); | |||
There was a problem hiding this comment.
I guess this has been done on purpose 🤔
Getting a bit confused about this, since it was just recently changed.
There was a problem hiding this comment.
oops sorry missed your comment before I hit the merge button
There was a problem hiding this comment.
Yeah, I had to revert it as were started getting random percentages on our widths (e.g., instead of 75%, 75.000000019% or so). Going with this for now with the shortened precision.
XhmikosR
approved these changes
Jun 22, 2021
marvin-hinkley-vortx
pushed a commit
to Vortx-Inc/bootstrap
that referenced
this pull request
Aug 18, 2021
* Fix another Sass division * Revert the percentage division in the mixins for accuracy Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34051
/cc @XhmikosR