Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix another Sass division #34332

Merged
merged 4 commits into from
Jun 22, 2021
Merged

Fix another Sass division #34332

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
915f18d
Fix another Sass division
mdo Jun 22, 2021
3f21d24
Merge branch 'main' into divide-grid-mixin
XhmikosR Jun 22, 2021
aa010c8
Revert the percentage division in the mixins for accuracy
mdo Jun 22, 2021
de93af2
Merge branch 'divide-grid-mixin' of https://github.com/twbs/bootstrap…
mdo Jun 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scss/mixins/_grid.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
@mixin make-col($size: false, $columns: $grid-columns) {
@if $size {
flex: 0 0 auto;
width: divide(100%, divide($columns, $size));
width: percentage(divide($size, $columns));
Copy link
Contributor

@alpadev alpadev Jun 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this has been done on purpose 🤔

Getting a bit confused about this, since it was just recently changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops sorry missed your comment before I hit the merge button

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I had to revert it as were started getting random percentages on our widths (e.g., instead of 75%, 75.000000019% or so). Going with this for now with the shortened precision.


} @else {
flex: 1 1 0;
Expand All @@ -43,7 +43,7 @@
}

@mixin make-col-offset($size, $columns: $grid-columns) {
$num: $size / $columns;
$num: divide($size, $columns);
margin-left: if($num == 0, 0, percentage($num));
}

Expand Down