Add rustfmt_toolchain #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbergman
force-pushed
the
rustfmt-toolchain
branch
from
19baacd to
736fd69
Compare
This makes the nixpkgs_rust_configure repo rule add a rustfmt_toolchain alongside rust_toolchain, using the same rustfmt binary as the former. Support for a separate toolchain for rustfmt was added in bazelbuild/rules_rust#1719.
lucasbergman
force-pushed
the
rustfmt-toolchain
branch
from
736fd69 to
ae69710
Compare
|
Hi, friends, anyone available for a (hopefully quick) review? |
malt3
approved these changes
Dec 11, 2024
|
Sorry for keeping you waiting. Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
nixpkgs_rust_configurerepo rule add arustfmt_toolchainalongside therust_toolchain, using the samerustfmtbinary as the former.I ran into this when trying to use the Prost support built into
rules_rustand it tried to download and invoke a non-nixpkgsrustfmt.I tried updating README files manually since
bazel run @rules_nixpkgs_docs//:update-README.mddidn't seem to do anything. If I'm just holding it wrong, sorry, just let me know.