Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added json request body support in csharp #686

Merged
merged 6 commits into from
Sep 9, 2023
Merged

Conversation

tiwarishubham635
Copy link
Contributor

Fixes

Added support for sending application/json(request body) in twilio-csharp

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@@ -0,0 +1,31 @@
using System;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't this.

@@ -0,0 +1,177 @@
using System;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is autogenerated code by librarian. We don't need this. Same comment for MessageCreator.

Copy link
Contributor Author

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unnecessary files

@sbansla sbansla merged commit efe312c into 7.0.0-rc Sep 9, 2023
6 of 7 checks passed
@sbansla sbansla deleted the json_request_body branch September 9, 2023 13:27
sbansla added a commit that referenced this pull request Feb 23, 2024
* chore: added custom converters for nested objects (#688)

* feat: added json request body support in csharp (#686)

* fix: Removed GetParams from Resource interface

* fix: removed unused abstract function getParam

* fix: removed unused constructor (#697)

* upgraded to .net6 (#690)

* build env changed to .net6

* picking dotnet version from global.json

* feat!: Generated code from oai-rc making lib MVR Ready
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants