Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added custom converters for nested objects #688

Merged
merged 2 commits into from
Sep 8, 2023
Merged

chore: added custom converters for nested objects #688

merged 2 commits into from
Sep 8, 2023

Conversation

sbansla
Copy link
Contributor

@sbansla sbansla commented Sep 8, 2023 •
edited
Loading

Fixes

Created custom converters for List of custom models and models.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sbansla sbansla changed the base branch from main to 7.0.0-rc September 8, 2023 06:17
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

tiwarishubham635
tiwarishubham635 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might not need UriConverters as discussed.

@sbansla sbansla merged commit 84a4c5c into 7.0.0-rc Sep 8, 2023
6 of 7 checks passed
@sbansla sbansla deleted the create-json-convertor branch September 8, 2023 11:27
tiwarishubham635 added a commit that referenced this pull request Sep 8, 2023
@tiwarishubham635 @sbansla
chore: added custom converters for nested objects (#688) (#689)
1cbfc59 
Co-authored-by: sbansla <104902068+sbansla@users.noreply.github.com>
sbansla added a commit that referenced this pull request Feb 23, 2024
@sbansla
feat!: MVR Ready (#728)
90cccf3 
* chore: added custom converters for nested objects (#688)

* feat: added json request body support in csharp (#686)

* fix: Removed GetParams from Resource interface

* fix: removed unused abstract function getParam

* fix: removed unused constructor (#697)

* upgraded to .net6 (#690)

* build env changed to .net6

* picking dotnet version from global.json

* feat!: Generated code from oai-rc making lib MVR Ready
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiwarishubham635 tiwarishubham635 tiwarishubham635 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbansla @tiwarishubham635