-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for iOS applications serving a webpage inside WKWebView #133
Conversation
…Safari). Solves the issue in the twilio-video library: twilio/twilio-video.js#1364
…iew (Safari). Solves the issue in the twilio-video library: twilio/twilio-video.js#1364
@manjeshbhargav Would it be possible to review this please? |
@manjeshbhargav Are you planning to review this? It's very important for many of us. |
Please could this be reviewed? The changes are straightforward and would be a big benefit to users of the platform |
+1 |
1 similar comment
+1 |
Asking once again to review please 👍 |
We patched this in our own fork and it works fine. An official release would be highly appreciated +1 |
Hate to do these kind of +1 comments, but if this is a blocker in supporting other browsers on iOS (all of which are WKWebViews) it would be much appreciated if it could be reviewed and merged. |
For anyone who needs it now there is a workaround: When initializing WKWebView add this code: if let ua = webView.value(forKey: "userAgent") as? String {
webView.customUserAgent = ua + " Safari"
} This will trick twilio-video.js into thinking it's running in normal Safari. |
Hi everyone! Thank you for all of your feedback and your patience with us. We have heard you and have merged VIDEO-8374 with @cbxp's suggestions and are in the process of releasing some time in the near future! I will now be closing this pull request. Thank you all once again! |
Solves an issue in the twilio-video library: twilio/twilio-video.js#1364
The following error is caused by getSdpFormat() which is not able to guess the browser if a webpage is rendered inside WKWebView in an iOS application.
Contributing to Twilio