Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iOS applications serving a webpage inside WKWebView #133

Closed
wants to merge 5 commits into from

Conversation

cbxp
Copy link

@cbxp cbxp commented Feb 11, 2021

Solves an issue in the twilio-video library: twilio/twilio-video.js#1364

The following error is caused by getSdpFormat() which is not able to guess the browser if a webpage is rendered inside WKWebView in an iOS application.

Calling setRemoteDescription with an RTCSessionDescription of type "answer" failed with the error "Failed to set remote answer sdp: The order of m-lines in answer doesn't match order in offer. Rejecting answer.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@noahmehl
Copy link

@manjeshbhargav Would it be possible to review this please?

@ac1dev
Copy link

ac1dev commented Apr 7, 2021

@manjeshbhargav Are you planning to review this? It's very important for many of us.

@shaun-nunns
Copy link

Please could this be reviewed?

The changes are straightforward and would be a big benefit to users of the platform

@lu-roth
Copy link

lu-roth commented Jun 23, 2021

+1

1 similar comment
@dcoughlin
Copy link

+1

@lu-roth
Copy link

lu-roth commented Aug 31, 2021

Asking once again to review please 👍

@dfox288
Copy link

dfox288 commented Sep 8, 2021

We patched this in our own fork and it works fine. An official release would be highly appreciated

+1

@lukewarlow
Copy link

Hate to do these kind of +1 comments, but if this is a blocker in supporting other browsers on iOS (all of which are WKWebViews) it would be much appreciated if it could be reviewed and merged.

@SergeyPoznyakAkvelon
Copy link

For anyone who needs it now there is a workaround:

When initializing WKWebView add this code:

if let ua = webView.value(forKey: "userAgent") as? String {
    webView.customUserAgent = ua + " Safari"
}

This will trick twilio-video.js into thinking it's running in normal Safari.

@PikaJoyce
Copy link
Contributor

Hi everyone!

Thank you for all of your feedback and your patience with us. We have heard you and have merged VIDEO-8374 with @cbxp's suggestions and are in the process of releasing some time in the near future!

I will now be closing this pull request.

Thank you all once again!
Joyce

@PikaJoyce PikaJoyce closed this Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants