VIDEO-8374 - Support for WKWebView/SFSafariViewController #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'Safari iOS - Slack ', | ||
| 'Mozilla/5.0 (iPhone; CPU iPhone OS 15_3 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.3 Mobile/15E148 Safari/604.1', | ||
| 'safari' | ||
| ], | ||
| [ |
There was a problem hiding this comment.
Is one of these user agents from Tim's app?
There was a problem hiding this comment.
Yes, the Safari-WKWebView - iPhone is from Tim's app.
and Safari iOS - Slack is the same as SFSafariViewController UA from Tim's app so it seems like most of the applications we tested on is using SFSafariViewController.
charliesantos
approved these changes
Feb 10, 2022
charliesantos
approved these changes
Feb 11, 2022
CHANGELOG.md
Outdated
| New Features | ||
| ------------ | ||
|
|
||
| - Enabled support for WKWebViews. |
There was a problem hiding this comment.
- Enabled support for WKWebViews. Thank you @codeborne for your contribution.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: VIDEO-8374
WKWebView Testing Notes
This small PR is for adding support for WKWebView to the SDK.
Contributing to Twilio