Skip to content

Commit

Permalink
Turn on mima checks on 0.17.x branch (#1706)
Browse files Browse the repository at this point in the history
* Estimator memory of container for mapper/reducer.

* Refactoring memory and reducer estimator

* Break out estimator tests into separate module (#1701)

* Revert "Cherry-pick memory estimator changes to 0.17.x branch (#1700)"

This reverts commit 9b8ea00.

* Try turning on mima

* Try newer ruby version

* Try latest jekyll version

* Try force

* Break out mima checks

* Fix bash weirdness when second command fails
  • Loading branch information
Piyush Narang authored Jul 14, 2017
1 parent 9971f9d commit 113cc29
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ before_install:
- export PATH=${PATH}:./vendor/bundle

install:
- rvm use 2.2.3 --install --fuzzy
- rvm use 2.2.6 --install --fuzzy
- gem update --system
- gem install sass
- gem install jekyll -v 3.2.1
- gem install jekyll -f -v 3.2.1

cache:
directories:
Expand Down
2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def youngestForwardCompatible(subProj: String) =
Some(subProj)
.filterNot(ignoredModules.contains(_))
.map {
s => "com.twitter" %% (s"scalding-$s") % "0.16.0"
s => "com.twitter" %% (s"scalding-$s") % "0.17.0"
}

def module(name: String) = {
Expand Down
9 changes: 7 additions & 2 deletions scripts/run_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,13 @@ echo "calling ... "
echo "time ./sbt ++$TRAVIS_SCALA_VERSION $(withCmd test)"
time ./sbt -Dhttp.keepAlive=false -Dsbt.repository.secure=false ++$TRAVIS_SCALA_VERSION "$(withCmd test)"
TST_EXIT_CODE=$?
echo "all done"

echo "Running mima checks ... "
echo "time ./sbt ++$TRAVIS_SCALA_VERSION $(withCmd mimaReportBinaryIssues)"
time ./sbt -Dhttp.keepAlive=false -Dsbt.repository.secure=false ++$TRAVIS_SCALA_VERSION "$(withCmd mimaReportBinaryIssues)"
MIMA_EXIT_CODE=$?

echo "all done"

$BASE_DIR/scripts/packDeps.sh
exit $TST_EXIT_CODE
exit $(( $TST_EXIT_CODE || $MIMA_EXIT_CODE ))

0 comments on commit 113cc29

Please sign in to comment.