Turn on mima checks on 0.17.x branch #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttim
approved these changes
Jul 13, 2017
|
Looks like the mimachecks are green on this build (they're failing as expected on develop). |
dieu
approved these changes
Jul 13, 2017
ttim
pushed a commit
to ttim/scalding
that referenced
this pull request
Jul 14, 2017
* Estimator memory of container for mapper/reducer. * Refactoring memory and reducer estimator * Break out estimator tests into separate module (twitter#1701) * Revert "Cherry-pick memory estimator changes to 0.17.x branch (twitter#1700)" This reverts commit 9b8ea00. * Try turning on mima * Try newer ruby version * Try latest jekyll version * Try force * Break out mima checks * Fix bash weirdness when second command fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turning on mimachecks on 0.17.x against the 0.17.0 release, while we decide on the right approach for the develop branch.