Change LzoTextLine() to LzoTextLine('line)?

[tanin47]

Here: https://github.com/twitter/scalding/blob/develop/scalding-commons/src/main/scala/com/twitter/scalding/commons/source/LzoTraits.scala#L72

It is because new LzoTextLine() will call TextLine's default constructor, which will return 2 columns: offset and line (http://docs.cascading.org/cascading/2.1/javadoc/cascading/scheme/hadoop/TextLine.html)

Please let me know what you think

[johnynek]

So, is the code currently broken? It seems like it is from your description. Can we confirm with a unit test, somehow?

Ideally, I'd love a test that is currently red, make PR, then a fix that gets it green. That would be rad.

[tanin47]

From what, I've found, yes.

Let me add a test case that verifies the problem. Thanks for the
suggestion, Oscar!

-Tanin

On Mon, Mar 10, 2014 at 10:48 AM, P. Oscar Boykin
notifications@git.luolix.topwrote:

So, is the code currently broken? It seems like it is from your
description. Can we confirm with a unit test, somehow?

Ideally, I'd love a test that is currently red, make PR, then a fix that
gets it green. That would be rad.

Reply to this email directly or view it on GitHubhttps://github.com//issues/817#issuecomment-37212128
.

@tanin

[jcoveney]

Closed by #921