Fix LzoTextLine as a TypedSource #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am testing this internally at Twitter |
| @@ -180,15 +180,15 @@ class Job(val args: Args) extends FieldConversions with java.io.Serializable { | |||
|
|
|||
| Config.overwrite(nonStrings, | |||
| defaultComparator.map(init.setDefaultComparator) | |||
| .getOrElse(init) | |||
There was a problem hiding this comment.
how did this happen with the plugin?
There was a problem hiding this comment.
Was wondering that myself. Maybe oscar's patch hadn't run scalariform? I don't think this is such a bad thing. Scalariform will carry us forward in an automated fashion. As long as the diffs aren't huge, shouldn't be a huge risk of merge conflicts.
|
Can we add a test with the local/platform tests for this? |
|
Testing with Lzo is very tricky because of the env stuff... |
|
Ahh, fair enough. Once your happy with it via manual tests, and green will merge. LGTM |
|
If someone has tested this internally, I say merge. |
johnynek
added a commit
that referenced
this pull request
Jun 30, 2014
Fix LzoTextLine as a TypedSource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LzoTextLine didn't work properly as a TypedSource