#5813 move js dir to top, second PR #6446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i am getting a directory "js/js/lab/lib" seems that should just be "js/lab/lib". |
scottdraves
reviewed
Dec 4, 2017
README.md
Outdated
| @@ -56,7 +56,7 @@ how to install and run BeakerX. | |||
| ``` | |||
| conda create -y -n beakerx 'python>=3' nodejs pandas openjdk maven | |||
| source activate beakerx | |||
| conda install -y -c conda-forge ipywidgets | |||
| conda install -y -c conda-forge ipywidgets jupyterlab | |||
There was a problem hiding this comment.
why add jupyterlab here? there's a separate section for that, see below.
|
done. |
michalgce
added a commit
that referenced
this pull request
Dec 11, 2017
* origin/master: (29 commits) fix typo add new contributing doc, cleanup readme #6483 (#6484) wheel is not usd to skip this release step #6470 Removed line that breaks use of virtualenvs (#6471) #6459 remove internal classes from javadoc (#6463) #6474 removed python 2 and added python 3.6 to setup.py (#6476) #6412 fix LoD menu breaks in lab (#6467) #6431: fix for unexpected return value (#6473) remove version lock, jupyterlab-manager is fixed #6439 Optimalisation of scala test execution. (#6454) #6157 version has 'tags/' (#6468) fix KernelExecutionTest (#6469) #6443: fix displaying widgets by fixing parent messages (#6464) jarek/6452: remove jvm-repr workaround (#6465) disable broken test disable broken test #6358 Fix docker language warnings. (#6448) update documentation to workaround jupyterlab/jupyterlab#3215 #5813 move js dir to top, second PR (#6446) #5643 make javadoc accessible (#6450) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.