Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5813 move js dir to top, second PR #6446

Merged
merged 4 commits into from
Dec 5, 2017
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ how to install and run BeakerX.
```
conda create -y -n beakerx 'python>=3' nodejs pandas openjdk maven
source activate beakerx
conda install -y -c conda-forge ipywidgets
conda install -y -c conda-forge ipywidgets jupyterlab
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add jupyterlab here? there's a separate section for that, see below.

(cd beakerx; pip install -e . --verbose)
beakerx-install
```
Expand Down Expand Up @@ -88,7 +88,7 @@ The notebook extensions are installed to run out of the repo, so just
a local build should suffice:

```
(cd beakerx/js; yarn install)
(cd js/notebook; yarn install)
```

## Groovy with Interactive Plotting and Tables:
Expand Down
6 changes: 3 additions & 3 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Create the release
------------------

Update the version in `beakerx/beakerx/_version.py` and
`beakerx/js/package.json` and `beakerx/jslab/package.json`. Commit
`beakerx/js/package.json` and `js/lab/package.json`. Commit
the change and push the git tag.

```bash
Expand Down Expand Up @@ -65,8 +65,8 @@ Publish on npmjs
To update the embedded version of our widget library:

- Do a full build.
- Run `(cd beakerx/js; npm publish)`
- Run `(cd beakerx/jslab; npm publish)`
- Run `(cd js/notebook; npm publish)`
- Run `(cd js/lab; npm publish)`

Release to Docker Hub
---------------------
Expand Down
6 changes: 3 additions & 3 deletions beakerx/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@
'java'
])
cmdclass['js'] = install_node_modules(
path='js',
build_dir=os.path.join(here, 'js', 'dist'),
source_dir=os.path.join(here, 'js', 'src')
path='../js/notebook',
build_dir=os.path.join(here, '../js/notebook', 'dist'),
source_dir=os.path.join(here, '../js/notebook', 'src')
)
cmdclass['java'] = run_gradle(cmd='build')

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ module.exports = [
entry: './src/extension.js',
output: {
filename: 'extension.js',
path: path.resolve(__dirname, '../beakerx/static'),
path: path.resolve(__dirname, '../../beakerx/beakerx/static'),
libraryTarget: 'amd'
},
module: {
Expand Down Expand Up @@ -114,7 +114,7 @@ module.exports = [
entry: './src/index.js',
output: {
filename: 'index.js',
path: path.resolve(__dirname, '../beakerx/static'),
path: path.resolve(__dirname, '../../beakerx/beakerx/static'),
libraryTarget: 'amd'
},
module: {
Expand Down Expand Up @@ -162,7 +162,7 @@ module.exports = [
entry: './src/embed.js',
output: {
filename: 'index.js',
path: path.resolve(__dirname, '../jslab/lib/'),
path: path.resolve(__dirname, '../js/lab/lib/'),
libraryTarget: 'amd'
},
module: {
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.