Force using latest node-gyp for nodegit, for Python 3 support #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most recent stable release of nodegit still depends on node-gyp ^4, which doesn't have Python 3 support. More recent versions support Python 3 and even drop Python 2. Until a non-alpha release of nodegit 0.28 is out, we can just override the dependency resolution, which seems to work fine. (Upstream nodegit did not make any interesting code changes when upgrading their node-gyp dependency.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent stable release of nodegit still depends on node-gyp ^4,
which doesn't have Python 3 support. More recent versions support Python
3 and even drop Python 2. Until a non-alpha release of nodegit 0.28 is
out, we can just override the dependency resolution, which seems to work
fine. (Upstream nodegit did not make any interesting code changes when
upgrading their node-gyp dependency.)