Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force using latest node-gyp for nodegit, for Python 3 support #881

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Force using latest node-gyp for nodegit, for Python 3 support #881

wants to merge 2 commits into from

Commits on Jan 23, 2023

  1. Run CI on Ubuntu 22.04 (no Python 2, hopefully)

    @geofft
    geofft committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    d1f2b23 View commit details
    Browse the repository at this point in the history

  2. Force using latest node-gyp for nodegit, for Python 3 support 

    The most recent stable release of nodegit still depends on node-gyp ^4,
which doesn't have Python 3 support. More recent versions support Python
3 and even drop Python 2. Until a non-alpha release of nodegit 0.28 is
out, we can just override the dependency resolution, which seems to work
fine. (Upstream nodegit did not make any interesting code changes when
upgrading their node-gyp dependency.)
    @geofft
    geofft committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    c0cfb3a View commit details
    Browse the repository at this point in the history