Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide host lookups #37

Closed
flokli opened this issue Oct 10, 2022 · 4 comments
Closed

provide host lookups #37

flokli opened this issue Oct 10, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@flokli
Copy link
Contributor

flokli commented Oct 10, 2022

Requires implementing at least:

  • RequestType::GETAI
  • RequestType::GETHOSTBYADDR
  • RequestType::GETHOSTBYADDRv6
  • RequestType::GETHOSTBYNAME
  • RequestType::GETHOSTBYNAMEv6
@flokli flokli mentioned this issue Oct 10, 2022
Merged
@flokli
Copy link
Contributor Author

flokli commented Oct 10, 2022

@NinjaTrappeur and I have been taking a closer look at this and will send a PR once ready, just wanted to give a heads-up :-)

@picnoir picnoir mentioned this issue Oct 11, 2022
Closed
This was referenced Oct 12, 2022
Merged
Closed
@flokli
Copy link
Contributor Author

flokli commented Oct 14, 2022

A branch containing all of #38, #39 and #40 can be found at my host-lookups branch. We sent individual PRs so things can be reviewed individually.

There's various people testing this on their systems, see NixOS/nixpkgs#135888 (comment) for details.

@leifwalsh leifwalsh mentioned this issue Oct 15, 2022
Closed
@leifwalsh leifwalsh added the enhancement New feature or request label Oct 15, 2022
@flokli flokli mentioned this issue Oct 20, 2022
Closed
@flokli
Copy link
Contributor Author

flokli commented Oct 20, 2022

We combined #39 and #40 into #49, so they can be reviewed as a single unit.

flokli added a commit to flokli/nixpkgs that referenced this issue Oct 20, 2022
@flokli
nsncd: init at unstable-2021-10-20
308548f 
This is currently pointing to a custom branch that contains the missing
request types from twosigma/nsncd#37, as well
as Type=notify support.
@de11n de11n mentioned this issue Apr 14, 2023
Open
@leifwalsh
Copy link
Collaborator

Done in #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement host lookups nix-community/nsncd
2 participants
@leifwalsh @flokli