-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime configuration #42
Labels
Comments
leifwalsh
added
enhancement
New feature or request
help wanted
Extra attention is needed
labels
Oct 15, 2022
https://docs.rs/config/latest/config/ and https://docs.rs/figment/latest/figment/ look promising at first glance. |
Clap also has support for env variables these days.
https://docs.rs/clap/latest/clap/builder/struct.Arg.html#method.env
…On Fri, Oct 14, 2022 at 9:09 PM Leif Walsh ***@***.***> wrote:
https://docs.rs/config/latest/config/ and
https://docs.rs/figment/latest/figment/ look promising at first glance.
—
Reply to this email directly, view it on GitHub
<#42 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEHQA3J2C4Y5FQJR6F6VG3WDH723ANCNFSM6AAAAAARFVR5ZU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
leifwalsh
added a commit
that referenced
this issue
Nov 19, 2022
This allows us to disable any request types we don't want nsncd to handle. fixes runtime configuration #42
leifwalsh
added a commit
that referenced
this issue
Nov 20, 2022
This allows us to disable any request types we don't want nsncd to handle. fixes runtime configuration #42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@flokli and @ninjatrappeur have been looking at adding support for more operations in #37.
The original purpose for, and our internal usage of, nsncd only needed user and group lookups to be served by nsncd, and while we're comfortable with the current performance and backpressure mechanisms, we have had some scares before where nsncd got overwhelmed by requests (hence #27 #28 #33 etc.). We're a little wary of adding more supported operations to our build.
I think we'd feel more comfortable if there were a way to configure which operations nsncd will handle, and all of us might appreciate runtime configuration anyway, to control the supported operations, threadpool settings, #15, etc.
I haven't looked at Rust configuration libraries but something that handles a common format like TOML and maybe supports environment variable overrides should be out there and sounds nice to me.
The text was updated successfully, but these errors were encountered: