Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime configuration #42

Closed
leifwalsh opened this issue Oct 15, 2022 · 2 comments · Fixed by #51
Closed

runtime configuration #42

leifwalsh opened this issue Oct 15, 2022 · 2 comments · Fixed by #51
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@leifwalsh
Copy link
Collaborator

@flokli and @ninjatrappeur have been looking at adding support for more operations in #37.

The original purpose for, and our internal usage of, nsncd only needed user and group lookups to be served by nsncd, and while we're comfortable with the current performance and backpressure mechanisms, we have had some scares before where nsncd got overwhelmed by requests (hence #27 #28 #33 etc.). We're a little wary of adding more supported operations to our build.

I think we'd feel more comfortable if there were a way to configure which operations nsncd will handle, and all of us might appreciate runtime configuration anyway, to control the supported operations, threadpool settings, #15, etc.

I haven't looked at Rust configuration libraries but something that handles a common format like TOML and maybe supports environment variable overrides should be out there and sounds nice to me.

@leifwalsh leifwalsh added enhancement New feature or request help wanted Extra attention is needed labels Oct 15, 2022
@leifwalsh
Copy link
Collaborator Author

https://docs.rs/config/latest/config/ and https://docs.rs/figment/latest/figment/ look promising at first glance.

@blinsay
Copy link
Collaborator

blinsay commented Oct 15, 2022 via email

leifwalsh added a commit that referenced this issue Nov 19, 2022
This allows us to disable any request types we don't want nsncd to
handle.

fixes runtime configuration #42
@leifwalsh leifwalsh linked a pull request Nov 19, 2022 that will close this issue
leifwalsh added a commit that referenced this issue Nov 20, 2022
This allows us to disable any request types we don't want nsncd to
handle.

fixes runtime configuration #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants