Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simple runtime configuration #51

Merged
merged 17 commits into from
Nov 20, 2022
Merged

add simple runtime configuration #51

merged 17 commits into from
Nov 20, 2022

Conversation

leifwalsh
Copy link
Collaborator

This allows us to disable any request types we don't want nsncd to handle.

fixes runtime configuration #42

This allows us to disable any request types we don't want nsncd to
handle.

fixes runtime configuration #42
@leifwalsh leifwalsh added the enhancement New feature or request label Nov 19, 2022
@leifwalsh leifwalsh self-assigned this Nov 19, 2022
@leifwalsh leifwalsh linked an issue Nov 19, 2022 that may be closed by this pull request
Cargo.toml Outdated Show resolved Hide resolved
@leifwalsh leifwalsh marked this pull request as draft November 19, 2022 22:55
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2022

Codecov Report

Base: 30.04% // Head: 41.60% // Increases project coverage by +11.55% 🎉

Coverage data is based on head (f9736cf) compared to base (82dd540).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #51       +/-   ##
===========================================
+ Coverage   30.04%   41.60%   +11.55%     
===========================================
  Files           5        6        +1     
  Lines         213      274       +61     
===========================================
+ Hits           64      114       +50     
- Misses        149      160       +11     
Impacted Files Coverage Δ
src/main.rs 0.00% <0.00%> (ø)
src/protocol.rs 40.90% <ø> (ø)
src/handlers.rs 33.33% <50.00%> (-2.23%) ⬇️
src/config.rs 85.96% <85.96%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leifwalsh
Copy link
Collaborator Author

Ok, I tried downgrading all the way to clap v2, whose API is miserable compared to modern clap, and it still doesn't compile on debian 10. I think I'm giving up on this path for now.

@leifwalsh leifwalsh marked this pull request as ready for review November 20, 2022 01:16
@leifwalsh leifwalsh enabled auto-merge (squash) November 20, 2022 01:19
@leifwalsh leifwalsh enabled auto-merge (squash) November 20, 2022 02:05
src/config.rs Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
src/protocol.rs Show resolved Hide resolved
src/config.rs Show resolved Hide resolved
src/config.rs Show resolved Hide resolved
@leifwalsh leifwalsh requested review from blinsay and flokli and removed request for flokli November 20, 2022 21:31
@leifwalsh leifwalsh merged commit 95957d3 into main Nov 20, 2022
@leifwalsh leifwalsh deleted the 42-runtime-configuration branch November 20, 2022 21:36
@flokli flokli mentioned this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime configuration
4 participants