Make worker threads and timeouts configurable. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow configuring the number of worker threads and handoff timeout with NSNCD_WORKER_COUNT and NSNCD_HANDOFF_TIMEOUT to tune cpu usage on busy hosts.
leifwalsh
approved these changes
Oct 30, 2021
Closed
domenkozar
reviewed
Feb 21, 2024
| @@ -75,15 +74,24 @@ fn main() -> Result<()> { | |||
|
|
|||
| let logger = slog::Logger::root(drain, slog::o!()); | |||
|
|
|||
| let worker_count = env_usize("NSNCD_WORKER_COUNT", 8); | |||
| let handoff_timeout = Duration::from_secs(env_usize("NSNCD_HANDOFF_TIMEOUT", 3) as u64); | |||
There was a problem hiding this comment.
3 seconds is way too low, at cachix.org we've been experiencing problems due to this. Can we make it 10?
There was a problem hiding this comment.
Are you able to tune the timeout with NSNCD_HANDOFF_TIMEOUT?
There was a problem hiding this comment.
Yes, however I'd much prefer a fix upstream.
There was a problem hiding this comment.
Can you open an issue where we can discuss this? Tell us more about what kind of load you're putting on nsncd at Cachix, how often you see the timeouts and on which calls, and what your upstream NSS calls are (e.g. are you reaching out to LDAP or some other networked service).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuring the number of worker threads and handoff timeout with
NSNCD_WORKER_COUNTandNSNCD_HANDOFF_TIMEOUTto tune cpu usage on busy hosts.This also changes the default number of workers from 256 to 8. We may want to roll that out separately.