[3.15] Add __class_getitem__ of classes
#582
Conversation
rest_framework-stubs/response.pyi
Outdated
| @@ -22,6 +23,7 @@ class Response(SimpleTemplateResponse): | |||
| exception: bool = ..., | |||
| content_type: str | None = ..., | |||
| ) -> None: ... | |||
| def __class_getitem__(cls, *args: Incomplete, **kwargs: Incomplete) -> Incomplete: ... | |||
There was a problem hiding this comment.
Please, provide correct types, Incomplete is not a good solution :(
There was a problem hiding this comment.
Thank you for letting me know the shortcomings! Is it okay to change only the response part for that type, or should I revise the other parts as well?
Please, provide correct types,
Incompleteis not a good solution :(
There was a problem hiding this comment.
All places, please :)
Here are examples: https://github.com/search?q=repo%3Apython%2Ftypeshed%20__class_getitem__&type=code
Oh... I sincerely appreciate you providing an example!! |
I have made things!
I added
__class_getitem__of classes in DRF version 3.15.The following are class items with
__class_getitem__added.fields.Field.__class_getitem__generics.GenericAPIView.__class_getitem__request.Request.__class_getitem__response.Response.__class_getitem__Related issues
Upstream PR: encode/django-rest-framework#8825