Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.15] Add __class_getitem__ of classes #585

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

JaeHyuckSa
Copy link
Contributor

@JaeHyuckSa JaeHyuckSa commented Apr 15, 2024

I have made things!

I added __class_getitem__ of classes in DRF version 3.15.

The following are class items with __class_getitem__ added.

  • fields.Field.__class_getitem__
  • generics.GenericAPIView.__class_getitem__
  • request.Request.__class_getitem__
  • response.Response.__class_getitem__

Related issues

Upstream PR: encode/django-rest-framework#8825

Related PR #582
I had PR deleted due to my mistake... I apologize.

@JaeHyuckSa JaeHyuckSa changed the title [3.15] Add __class_getitem__ of classes [3.15] Add __class_getitem__ of classes Apr 15, 2024
@JaeHyuckSa
Copy link
Contributor Author

JaeHyuckSa commented Apr 15, 2024

Regarding your inquiry, is it better to coordinate the current BaseSerializer __class_getitem__?

def __class_getitem__(cls, *args: Incomplete, **kwargs: Incomplete) -> Incomplete: ...

@sobolevn sobolevn merged commit 23a4928 into typeddjango:master Apr 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants