Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to scalatest 3.1.0 #2761

Closed
kailuowang opened this issue Mar 26, 2019 · 7 comments
Closed

Upgrade to scalatest 3.1.0 #2761

kailuowang opened this issue Mar 26, 2019 · 7 comments
Labels

Comments

@kailuowang
Copy link
Contributor

kailuowang commented Mar 26, 2019

Scalatest 3.1.0 is yet to be released.
We need to upgrade this to avoid potential compatibility issue with scalacheck 1.14 before we can release 2.0

@kailuowang kailuowang added this to the 2.0 milestone Mar 26, 2019
@kailuowang kailuowang changed the title Upgrade to scalatest 3.10 Upgrade to scalatest 3.1.0 Mar 27, 2019
@kailuowang kailuowang modified the milestones: 2.0.0-M1, 2.0.0-RC1 Apr 18, 2019
@erwan
Copy link

erwan commented Jul 15, 2019

Do we have visibility on scalatest roadmap? Scalatest 3.1.0 is still not released, should this ticket still block cats 2.0?

@kailuowang
Copy link
Contributor Author

Due to compatibility with scalacheck on Scala 2.13
, Cats-testkit has to depend on scalatest 3.1.0 . I am on my vacation ATM. I will try find a solution to unblock later this week.

@nafg
Copy link

nafg commented Jul 29, 2019

Here's the "countdown": scalatest/scalatest#1656

@julienrf
Copy link
Contributor

julienrf commented Jul 31, 2019

Cats-testkit has to depend on scalatest 3.1.0

May I ask what is the reason for that? In #2806 it doesn’t seem that testkit relies on a specific feature of 3.1.0.

Scalatest 3.0.8 is now available for Scala 2.13.0, so it should be possible to revert #2806 and still get 2.13 support.

@kailuowang
Copy link
Contributor Author

kailuowang commented Jul 31, 2019

@julienrf
The reason is Scalacheck. Scalatest 3.0.x doesn't support Scalacheck 1.14 which is the only Scalacheck version that supports Scala 2.13.
I am on vacation right now. But if anyone has the time to extract the scalatest dependent part from cats testkit out to a separate module and set it to be not published, and upstate the document teaching people how to integrate with scalatest themselves, I think I can find time to review and help release (or other maintainers can do too).
I will be back Aug 5

@nafg
Copy link

nafg commented Aug 1, 2019

So then how were cats 2.0-M4 and scalatest 3.0.8 built for scala 2.13?

@nafg
Copy link

nafg commented Aug 1, 2019

Also, what's stopping an earlier version of scalacheck from being published for scala 2.13?

@kailuowang kailuowang removed this from the 2.0.0-RC1 milestone Aug 2, 2019
@larsrh larsrh closed this as completed Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants
@erwan @kailuowang @nafg @julienrf @larsrh and others