upgrade to scalacheck 1.14

[kailuowang]

No description provided.

[ceedubs]

It looks like there are some differences in the format of strings in some of the SBT doctests. TBH I'm not sure why this PR would have changed these though? Maybe it changed some Scalacheck Pretty instances?

'Some((List(1, 2, 3, 4),List()))' is not equal to 'Some((List(1, 2, 3, 4), List()))'

'Some(Right(n))' is not equal to 'Some(Right('n'))'

[ceedubs]

Hmm actually upon closer inspection it looks like we already have this problem, and somehow this change just makes the build detect the failure. I'll submit a PR for master.

[kailuowang]

close reopen to fix travis glitch

[codecov-io]

Codecov Report

Merging #2734 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2734      +/-   ##
==========================================
- Coverage   95.33%   95.24%   -0.09%     
==========================================
  Files         363      365       +2     
  Lines        6771     6857      +86     
  Branches      291      295       +4     
==========================================
+ Hits         6455     6531      +76     
- Misses        316      326      +10

Impacted Files	Coverage Δ
core/src/main/scala/cats/data/ContT.scala	100% <0%> (ø)	⬆️
laws/src/main/scala/cats/laws/MonadLaws.scala	100% <0%> (ø)	⬆️
js/src/main/scala/cats/js/instances/future.scala	0% <0%> (ø)
...patTest/src/main/scala/catsBC/MimaExceptions.scala	0% <0%> (ø)
core/src/main/scala/cats/data/Ior.scala	98.54% <0%> (+0.01%)	⬆️
core/src/main/scala/cats/Eval.scala	98.82% <0%> (+0.04%)	⬆️
core/src/main/scala/cats/data/IorT.scala	97.79% <0%> (+0.04%)	⬆️
core/src/main/scala/cats/data/NonEmptyChain.scala	99.07% <0%> (+0.92%)	⬆️
free/src/main/scala/cats/free/Free.scala	93.57% <0%> (+1.47%)	⬆️
.../src/main/scala/cats/data/RepresentableStore.scala	87.5% <0%> (+4.16%)	⬆️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0e5bf...430b738. Read the comment docs.

[travisbrown]

Shouldn't this happen in sync with the upcoming ScalaTest 3.1.0 release, which is the first (legitimate) release that depends on ScalaCheck 1.14? There will also need to be a new Discipline release.

Even if all tests pass here just fine, I'm concerned that mixing ScalaTest 3.0 and 3.1 and ScalaCheck 1.13 and 1.14 is going to cause problems and impose a lot of unnecessary fuss and worry on users of downstream libraries like circe-testing.

[kailuowang]

@travisbrown that's a valid concern. We can wait for scalatest 3.1.0

[kailuowang]

@travisbrown we need to merge this to fix #2758 to fix build. In the mean time I created an issue #2761 to make sure that we upgrade to coming Scalatest 3.10 before our Cats next release

[SethTisue]

🎉